Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run release triggered main pipeline integration tests at concurrency 1 #5047

Merged

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Mar 14, 2025

Changes

  • Add j parameter to just command to control concurrency of integration tests
  • Add buildkite controls for the parameter
  • Set concurrency to 1 when building for release pipeline

Issue

#5045

Notes

@paolino paolino self-assigned this Mar 14, 2025
@paolino paolino added the CI CI related label Mar 14, 2025
@paolino paolino requested a review from abailly March 14, 2025 17:43
Copy link
Collaborator

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentioned in your message, it's unclear whether running tests concurrently is the issue.
I had a Quick Look at the source code for the particular failure.
It seems to me we are trying to reimplement a function that already exists in the process package, namely readCreateProcessWithExitCode, albeit without taking care of the possibility of SIGPIPE being triggered, nor of the ordering of operations: Perhaps reading the pipe after closing the input stream leads to the underlying process to terminate and therefore the pipe to be closed?
I haven't tested it, but adding a delay after the hClose might surface the issue more consistently.

@paolino paolino force-pushed the paolino/5045/run-release-build-integration-tests-at-j1 branch 2 times, most recently from c8b9776 to 76da6c5 Compare March 17, 2025 08:57
@paolino paolino requested a review from abailly March 18, 2025 11:58
@paolino paolino force-pushed the paolino/5045/run-release-build-integration-tests-at-j1 branch 2 times, most recently from 922f79e to 52669fd Compare March 18, 2025 15:59
@paolino paolino enabled auto-merge March 18, 2025 16:22
@paolino paolino added this pull request to the merge queue Mar 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 18, 2025
@paolino paolino force-pushed the paolino/5045/run-release-build-integration-tests-at-j1 branch from 52669fd to 6803540 Compare March 18, 2025 16:36
@paolino paolino enabled auto-merge March 18, 2025 16:36
@paolino paolino added this pull request to the merge queue Mar 18, 2025
Merged via the queue into master with commit cb7af51 Mar 18, 2025
28 checks passed
@paolino paolino deleted the paolino/5045/run-release-build-integration-tests-at-j1 branch March 18, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants