Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networking options for Ouroboros Genesis #1405

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

Networking options for Ouroboros Genesis #1405

wants to merge 3 commits into from

Conversation

crocodile-dentist
Copy link

p2p added notes for network options for Ouroboros Genesis

Merge after #1387

rphair
rphair approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great technical material, as well as improvements to writing style. Will also set to Draft as per #1387 (review) - until the next node minor release - but please other reviewers continue to review this material in the meantime.

@rphair rphair added the documentation Improvements or additions to documentation label Feb 19, 2025
@rphair rphair marked this pull request as draft February 19, 2025 16:48
@rphair rphair requested review from rdlrt, katomm and gitmachtl February 19, 2025 17:13
@rphair
Copy link
Collaborator

rphair commented Feb 20, 2025

@crocodile-dentist I'm assuming that the 10.2.1 tagged Pre-release does not justify putting this change through: please let us know if you think it does.

@crocodile-dentist
Copy link
Author

I think what you're saying is reasonable and we can wait for a regular release before publishing these notes. It is a possibility that 10.2.1 might be switched to a regular release so we might have to keep our fingers on the pulse.

@rphair
Copy link
Collaborator

rphair commented Feb 20, 2025

(note the last commit only checked spelling in newly introduced text... not the unchanged material)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm Awaiting requested review from katomm

@gitmachtl gitmachtl Awaiting requested review from gitmachtl

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crocodile-dentist @rphair @rdlrt