-
Notifications
You must be signed in to change notification settings - Fork 24
feat(core): migrate group scoped name #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimcase
wants to merge
119
commits into
VT20-1919-create-group-profile
Choose a base branch
from
feature/cherypick-migrate-group-name
base: VT20-1919-create-group-profile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): migrate group scoped name #1265
jimcase
wants to merge
119
commits into
VT20-1919-create-group-profile
from
feature/cherypick-migrate-group-name
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vu Van Duc <[email protected]>
Sotatek-DukeVu
approved these changes
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
reviewed
Jul 22, 2025
iFergal
approved these changes
Jul 22, 2025
4 tasks
656c40a
to
3d1f69b
Compare
iFergal
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, each identifier has only 1 display name, and the entire wallet has a username which is shared with connections. In the new account based flow, this global username is being removed.
Instead:
We will share the display name of individual identifiers
Groups will have a group name (same as display name), and a “username” per group
The group name is shared with connections
The username is shared with other members of the group when setting up the group
Refactor defaultProfile to currentAccount
The selected profile is moved and refactored to
stateCache
, outside of Authentification Object, as it is independent of the auth. See here:New methods:
New method file habName to parse the identifier names:
New format example:
1.2.0.3:theme:isInitiator-groupId-userName:displayName
parseHabName
is a utility function designed to deconstruct a structured "hab name" string into its individual components. It takes a single name: string argument, which is expected to follow the formatversion:isInitiator-group_id-username:display_name
. The function then parses this string and returns an object of typeHabNameParts
, providing programmatic access to extracted fields such asversion
,isInitiator
(a boolean indicating if the current entity is the group initiator),groupId
,userName
, anddisplayName
.formatToV1_2_0_3
is a utility function that constructs a "hab name" string from its individual components, specifically adhering to the1.2.0.3
version format. It takes an object of type HabNameParts (which contains fields like version, isInitiator, groupId, userName, and displayName
) and serializes them into the precise stringformat
version:isInitiator-group_id-username:display_name
.Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review