feat(ui): Migrate old Identifier Details page into Profile Details #1270

Sotatek-DukeVu · 2025-07-17T11:25:46Z

Description

Migrate old Identifier Details page into Profile Details

Checklist before requesting a review

Issue ticket number and link

This PR has a valid ticket number or issue: VT20-1994

Testing & Validation

This PR has been tested/validated in iOS, Android and browser.
Added new unit tests, if relevant.

Design Review

In case this PR contains changes to the UI, add some screenshots and/or videos to show the changes on relevant devices.

Set recent profile as default profile when user delete default profile

Screen.Recording.2025-07-21.at.16.12.24.mov

IOS

Screen.Recording.2025-07-21.at.16.02.11.mov

Android

Screen.Recording.2025-07-21.at.17.28.58.mov

Co-authored-by: Vu Van Duc <[email protected]>

sdisalvo-crd · 2025-07-18T09:22:25Z

src/locales/en/en.json

+        "color": "Choose card colour"
+      }
+    },
+    "clouderror": "We couldn’t locate this identifier in the cloud. It might become available again soon, but some information could be lost.\n\nIf you no longer require this identifier, tap “Delete identifier” to remove.",


Update message

sdisalvo-crd

A few more comments on some naming issues and a reminder about what we talked about in DM for sorting profiles alphabetically and setting up a history of default profiles so we can fall back on the most recently used when deleting one in use.

sdisalvo-crd · 2025-07-18T09:25:20Z

src/locales/en/en.json

+      }
+    },
+    "rotatekeys": {
+      "message": "After rotating your keys, you may experience some delays when using this identifier for a short period.",


Update message

sdisalvo-crd · 2025-07-18T09:32:34Z

src/locales/en/en.json

+        "title": "Advanced details",
+        "propexplain": {
+          "title": "About advanced details",
+          "content": "Provides additional details on this identifier for users interested in more technical insights."


Update message and check space below the header and between elements as they seem very close to each other (but I might be wrong).

sdisalvo-crd · 2025-07-18T09:39:58Z

src/ui/components/CredentialDetailModule/components/CredentialContent.tsx

@@ -24,7 +24,7 @@ import {
 } from "../../CardDetails";
 import { CardTheme } from "../../CardTheme";
 import { FallbackIcon } from "../../FallbackIcon";
-import { IdentifierDetailModal } from "../../IdentifierDetailModule";
+import { ProfileDetailModal } from "../../ProfileDetailModal";


Should rename all Detail to Details just to be correct.

sdisalvo-crd · 2025-07-18T09:41:45Z

src/ui/components/ProfileDetailModal/ProfileDetailModal.scss

@@ -0,0 +1,257 @@
+.identifier-details-module {


All ProfileDetailModal files should be renamed to include s in Details

sdisalvo-crd · 2025-07-18T09:43:00Z

src/ui/components/ProfileDetailModal/ProfileDetailModal.tsx

+  ProfileDetailModalProps,
+} from "./ProfileDetailModal.types";
+
+const ProfileDetailModule = ({


Same as mentioned before, add missing s in the name.

sdisalvo-crd · 2025-07-18T09:49:10Z

src/locales/en/en.json

+        "title": "Signing threshold",
+        "propexplain": {
+          "title": "About signing threshold",
+          "content": "Minimum number of signing keys required to approve a transaction or event within the identifier."


Please check this design update to see new updated messages for profiles: https://www.figma.com/design/xDtjsTapugXYhlUvwdCq49/Veridian-App?node-id=7514-27000&t=estZuNZWzhzD0C9W-1

sdisalvo-crd · 2025-07-18T09:49:43Z

src/ui/components/ProfileDetailModal/ProfileDetailModal.types.ts

@@ -1,18 +1,17 @@
 import { HardwareBackButtonConfig } from "../PageHeader/PageHeader.types";

-interface IdentifierDetailModuleProps {
+interface ProfileDetailModalProps {


Change to ProfileDetailsModalProps

sdisalvo-crd · 2025-07-18T09:50:11Z

src/ui/components/ProfileDetailModal/components/IdentifierAttributeDetailModal/Advanced.tsx

-                        <span>
-                          {i18n.t("tabs.identifiers.details.detailmodal.you")}
-                        </span>
+                        <span>{i18n.t("profiledetails.detailmodal.you")}</span>


Change to detailsmodal

sdisalvo-crd · 2025-07-18T09:50:57Z

src/locales/en/en.json

+      }
+    },
+    "clouderror": "We couldn’t locate this identifier in the cloud. It might become available again soon, but some information could be lost.\n\nIf you no longer require this identifier, tap “Delete identifier” to remove.",
+    "detailmodal": {


Change to detailsmodal (missing s).

sdisalvo-crd · 2025-07-18T09:53:56Z

src/ui/components/ProfileDetailModal/components/IdentifierContent.types.ts

+interface IdentifierContentProps {
+  oobi: string;
+  cardData: IdentifierDetails;
+  onRotateKey: () => void;
+  setCardData: (value: IdentifierDetails) => void;
+}
+
+interface ProfileInformationProps {
+  value: string;
+  text: string;
+}


Looks like we're now mixing Identifier and Profile. Maybe we rename all components that use Identifier as name to Profile just to be consistent? It's ok to leave identifier in core data though, just UI components.

…perly (develop) (#1273) * fix(core): ipex agree filtering for connection history * refactor: save exchangepresentcredential later to minimize race conditions

jimcase · 2025-07-22T09:41:39Z

.nsprc

+  },
+  "1106462": {
+    "active": true,
+    "notes": "Appium server responses when e2e testing is unlikely to impact the wallet."


There is a new vulnerability, see here: https://github.com/cardano-foundation/veridian-wallet/pull/1265/files#diff-ef83f36aceb5c154be3decd7e4d1ea95056a5b961c69b87f0d0e983c83d265ecL23-R26

Done. Please check.

jimcase · 2025-07-22T09:49:55Z

src/store/reducers/identifiersCache/identifiersCache.test.ts

@@ -324,35 +261,6 @@ describe("get identifier Cache", () => {
    expect(identifiersCache).toEqual(state.identifiersCache.identifiers);
  });

-  test("should return the favourites cache from RootState", () => {


should we have a test for return the favourites for creds

We did it. Please check: https://github.com/cardano-foundation/veridian-wallet/blob/main/src/store/reducers/credsCache/credsCache.test.ts#L219

jimcase · 2025-07-22T15:13:32Z

src/ui/components/CardSlider/CardSlider.tsx

-  const favouriteIndex = isIdentifier
-    ? identifierFavouriteIndex
-    : credFavouriteIndex;
+  const favouriteIndex = credFavouriteIndex;


We can use credFavouriteIndex directly

jimcase · 2025-07-22T15:19:03Z

src/ui/components/ProfileDetailsModal/ProfileDetailsModal.test.tsx

@@ -48,7 +50,7 @@ Object.defineProperty(window, "matchMedia", {
  })),
 });

-const path = TabsRoutePath.IDENTIFIERS + "/" + identifierFix[0].id;
+const path = TabsRoutePath.CREDENTIALS + "/" + identifierFix[0].id;


We can use string interpolation here:

${TabsRoutePath.CREDENTIALS}/${identifierFix[0].id}

jimcase · 2025-07-22T15:29:22Z

src/ui/hooks/useProfile.ts

+      return true;
+    }
+
+    const identifies = Object.values(identifierMap)


typo: identifiers

feat(ui): fix missing default profile after recovery wallet (#1260)

b352e24

Co-authored-by: Vu Van Duc <[email protected]>

Sotatek-DukeVu requested a review from sdisalvo-crd as a code owner July 17, 2025 11:25

Sotatek-DukeVu removed the request for review from sdisalvo-crd July 17, 2025 11:25

Sotatek-DukeVu marked this pull request as draft July 17, 2025 11:25

Sotatek-DukeVu self-assigned this Jul 17, 2025

Sotatek-DukeVu marked this pull request as ready for review July 18, 2025 03:06

Sotatek-DukeVu force-pushed the VT20-1994-migrate-old-identifier-details-page-into-profile-details branch from bb4f0c2 to e5d2f9c Compare July 18, 2025 07:45

chore: update nsprc

d6cda33

sdisalvo-crd reviewed Jul 18, 2025

View reviewed changes

iFergal and others added 4 commits July 18, 2025 11:16

fix(core): ipex agree connection history items not being filtered pro…

ca11e10

…perly (develop) (#1273) * fix(core): ipex agree filtering for connection history * refactor: save exchangepresentcredential later to minimize race conditions

feat(ui): rename settings

2b38bac

feat(ui): profile detail modal

1a8d7c8

feat(ui): remove identifier view type

11c178f

Sotatek-DukeVu force-pushed the VT20-1994-migrate-old-identifier-details-page-into-profile-details branch 2 times, most recently from 2e443d5 to 2884666 Compare July 21, 2025 04:17

feat(ui): fix review comments

9de652e

Sotatek-DukeVu force-pushed the VT20-1994-migrate-old-identifier-details-page-into-profile-details branch from 5bfa14b to 9de652e Compare July 21, 2025 10:20

Sotatek-DukeVu requested a review from sdisalvo-crd July 21, 2025 10:30

jorgenavben requested a review from jimcase July 22, 2025 09:23

jimcase reviewed Jul 22, 2025

View reviewed changes

fix(ui): fix review comments

b7c8511

Sotatek-DukeVu requested a review from jimcase July 23, 2025 03:12

jimcase approved these changes Jul 23, 2025

View reviewed changes

Sotatek-DukeVu requested a review from obstar July 23, 2025 08:54

feat(ui): Migrate old Identifier Details page into Profile Details #1270

Are you sure you want to change the base?

feat(ui): Migrate old Identifier Details page into Profile Details #1270

Uh oh!

Conversation

Sotatek-DukeVu commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist before requesting a review

Issue ticket number and link

Testing & Validation

Design Review

Set recent profile as default profile when user delete default profile

IOS

Android

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdisalvo-crd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jimcase Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sotatek-DukeVu commented Jul 17, 2025 •

edited

Loading

jimcase Jul 22, 2025 •

edited

Loading