feat(core): align connection note and connection history item IDs… #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the cloud with new schema
4 tasks
…ection details retrieval and deletion
iFergal
reviewed
Jul 30, 2025
| if (identifier) { | ||
| const connectionPair = await this.connectionPairStorage.findById( | ||
| `${identifier}:${contactId}` | ||
| ); |
There was a problem hiding this comment.
I think we can move this logic to getConnectionShortDetailById so it's easier to follow. getContactMetadataById should just return a contact, not a full connection.
There was a problem hiding this comment.
And then we can remove the ContactDetailsRecord type
There was a problem hiding this comment.
I don’t think so. We have the getConnectionShortDetails function calling this, and it requires the full connection. Also, getConnectionShortDetails is called from many places
src/ui/components/CredentialDetailModule/CredentialDetailModule.tsx
Outdated
Show resolved
Hide resolved
| @@ -313,14 +316,15 @@ class ConnectionService extends AgentService { | |||
| contactId: record.id, | |||
| ...(record.groupId | |||
| ? { groupId: record.groupId } | |||
| : { identifier: record.identifier }), | |||
| : { identifier: record.identifier ?? "" }), | |||
| }; | |||
| } | |||
|
|
|||
| @OnlineOnly | |||
| async getConnectionById( | |||
| id: string, | |||
There was a problem hiding this comment.
Maybe rename to id to contactId everywhere we are passing the contact ID tbh
…nnectionById in IPEX communication service
…re identifier and enhance related tests
…tails in CredentialDetailModule, ConnectionDetails, and Connections components for improved type safety
…tails for improved type safety and consistency
…tions components for enhanced type safety
…parameter across notification and communication services
iFergal
reviewed
Jul 31, 2025
| @@ -109,7 +109,8 @@ const CredentialDetailModule = ({ | |||
| await Agent.agent.connections.getConnectionShortDetailById( | |||
| connectionId | |||
| ); | |||
| setConnectionShortDetails(shortDetails); | |||
| // Credentials are only associated with regular connections | |||
| setConnectionShortDetails(shortDetails as RegularConnectionDetails); | |||
There was a problem hiding this comment.
Lets use function overloads to tighten things, and remove our usage of as.
async getConnectionShortDetailById(id: string): Promise<MultisigConnectionDetails>
async getConnectionShortDetailById(id: string, identifier: string): Promise<RegularConnectionDetails>;
async getConnectionShortDetailById(
id: string,
identifier?: string
): Promise<MultisigConnectionDetails | RegularConnectionDetails> {
We might be able to remove ConnectionShortDetails completely which forces our functions to overload correctly like this.
| setNotes(connectionDetails.notes || []); | ||
| setConnectionHistory(connectionDetails.historyItems || []); | ||
| // Since this component only handles regular connections, cast to RegularConnectionDetailsFull | ||
| setConnectionDetails(connectionDetails as RegularConnectionDetailsFull); |
| @@ -120,7 +120,8 @@ const Connections = () => { | |||
| const getConnectionShortDetails = async (connectionId: string) => { | |||
| const shortDetails = | |||
| await Agent.agent.connections.getConnectionShortDetailById(connectionId); | |||
| setConnectionShortDetails(shortDetails); | |||
| // Connections page only shows details for regular connections | |||
| setConnectionShortDetails(shortDetails as RegularConnectionDetails); | |||
…nd removed the usage of as type assertions in the connection-related code.
…0-1912-align-connection-note-and-history-in-the-clould-with-new-schema
jimcase
approved these changes
Aug 1, 2025
* feat: recovery contacts per identifier * fix: getAllIdentifiers * fix: vuln id * fix: contact.createdAt * fix: date in unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align connection note and connection history item IDs in the cloud with new schema
Checklist before requesting a review
Issue ticket number and link
Testing & Validation