feat(ui): Profile Details View #1290
Draft
+5,243
−12,882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-identifier-details-page-into-profile-details feat(ui): Migrate old Identifier Details page into Profile Details
…d-cardano-connect-modal feat(ui): Migrate old Cardano Connect modal
…g identifiers (#1292) * feat(ui): remove notification slice * feat(ui): remove cred slices * feat(ui): remove identifier slice * feat(ui): update UT * feat(ui): fix bug * feat(ui): fix audit --------- Co-authored-by: Vu Van Duc <[email protected]>
sdisalvo-crd
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Approved in the previous PR and merged as it overall works pretty well and I didn't want to delay things, but I have noticed a few minor things I would like you to check and fix here.
- The space above the header seems inconsistent across screens. Please check all pages and make a small adjustment.
- If you have a profile, then create another one and delete one, you will be asked to create a profile.
01082025131852.mp4
- Switching between an empty credentials tab and an empty Connections tab shows a little jump in the placeholder image.
01082025132127.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement profile detail view.
Related PR:
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
Profile modal
IOS
Screen.Recording.2025-07-21.at.16.02.11.mov
Android
Screen.Recording.2025-07-21.at.17.28.58.mov
dApp connect
IOS
Screen.Recording.2025-07-22.at.16.23.31.mov
Android
Screen.Recording.2025-07-22.at.16.33.03.mov