feat: hook peer connect UI to the core #494

Sotatek-HocNguyena · 2024-05-27T09:07:05Z

Description

Replace mocked functions for retrieving and adding new peer connect connections to the core
Integrate the sign data request with the incoming request queue

Checklist before requesting a review

Issue ticket number and link

This PR has a valid ticket number or issue:

Testing & Validation

This PR has been tested/validated in IOS, Android and browser.
The code has been tested locally with test coverage match expectations.
Added new Unit/Component testing (if relevant).

Security

No secrets are being committed (i.e. credentials, PII)
This PR does not have any significant security implications

Code Review

There is no unused functionality or blocks of commented out code (otherwise, please explain below)
In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
In case PR contains changes to the UI, add some screenshots to notice the differences

Browser

Screencast.from.29-05-2024.15.09.30.webm

Screencast.from.29-05-2024.15.01.41.webm

…allet into feat/hook-up-peer-connect-to-the-UI

github-actions · 2024-05-27T09:14:27Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-lhibv6j5x.vercel.app

src/core/cardano/walletConnect/peerConnection.ts

src/store/reducers/stateCache/stateCache.types.ts

src/store/reducers/walletConnectionsCache/walletConnectionsCache.test.ts

src/store/reducers/walletConnectionsCache/walletConnectionsCache.ts

src/ui/pages/SidePage/components/WalletConnect/WalletConnectStageTwo.tsx

src/ui/pages/SidePage/components/IncomingRequest/IncomingRequest.tsx

src/ui/pages/SidePage/components/WalletConnect/WalletConnectStageTwo.tsx

src/store/reducers/walletConnectionsCache/walletConnectionsCache.test.ts

src/core/cardano/walletConnect/peerConnection.ts

src/ui/pages/Menu/components/ConnectWallet/ConnectWallet.tsx

src/locales/en/en.json

src/ui/__fixtures__/signTransactionFix.ts

src/ui/pages/SidePage/components/IncomingRequest/components/RequestComponent.test.tsx

src/ui/pages/SidePage/components/IncomingRequest/components/SignTransactionRequest.tsx

src/ui/pages/SidePage/components/IncomingRequest/IncomingRequest.tsx

src/ui/pages/SidePage/components/IncomingRequest/components/SignTransactionRequest.tsx

src/ui/components/AppWrapper/AppWrapper.tsx

github-actions · 2024-05-28T11:32:20Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-2puxt7x97.vercel.app

github-actions · 2024-05-29T04:39:47Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-4w5mmbcha.vercel.app

…allet into feat/hook-up-peer-connect-to-the-UI

src/locales/en/en.json

src/ui/components/AppWrapper/AppWrapper.tsx

src/ui/pages/Menu/components/ConnectWallet/ConnectWallet.tsx

src/ui/pages/SidePage/components/IncomingRequest/components/SignRequest.tsx

src/locales/en/en.json

src/ui/components/AppWrapper/AppWrapper.tsx

src/ui/pages/SidePage/components/WalletConnect/WalletConnectStageTwo.tsx

github-actions · 2024-05-29T09:03:58Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-1ws9bmpf7.vercel.app

src/ui/components/AppWrapper/AppWrapper.tsx

github-actions · 2024-05-29T10:51:29Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-7t75raxnv.vercel.app

…ated

github-actions · 2024-05-29T11:06:33Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-b1jh7okwx.vercel.app

github-actions · 2024-05-30T08:53:36Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-q50tw81mm.vercel.app

github-actions · 2024-05-31T04:49:02Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-e3jx2058n.vercel.app

src/core/cardano/walletConnect/peerConnection.ts

src/ui/components/AppWrapper/AppWrapper.tsx

…allet into feat/hook-up-peer-connect-to-the-UI

github-actions · 2024-06-04T01:58:34Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ptekvzv1c.vercel.app

github-actions · 2024-06-04T09:55:29Z

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-9ebkqbozl.vercel.app

feat: replace mock peerconnection with the real functions

7c2f3c6

Sotatek-HocNguyena requested a review from iFergal May 27, 2024 09:07

Sotatek-HocNguyena self-assigned this May 27, 2024

Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…

e4d65c3

…allet into feat/hook-up-peer-connect-to-the-UI

iFergal reviewed May 27, 2024

View reviewed changes

src/core/cardano/walletConnect/peerConnection.ts Outdated Show resolved Hide resolved

refactor: update sign so it can sign arbitrary data

46e27ff

Sotatek-HocNguyena marked this pull request as ready for review May 28, 2024 10:02

refactor: update sign so it can sign arbitrary data

5743df9

iFergal reviewed May 28, 2024

View reviewed changes

update: small UI updates

7e62b67

update: small UI updates

ce9cc21

Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…

6f3510f

…allet into feat/hook-up-peer-connect-to-the-UI

iFergal reviewed May 29, 2024

View reviewed changes

iFergal changed the title ~~feat: replace mock peerconnection with the real functions~~ feat: hook peer connect UI to the core May 29, 2024

Sotatek-DukeVu reviewed May 29, 2024

View reviewed changes

src/ui/pages/SidePage/components/WalletConnect/WalletConnectStageTwo.tsx Outdated Show resolved Hide resolved

refactor: rename css classes and event type

71b4c1d

iFergal reviewed May 29, 2024

View reviewed changes

src/ui/components/AppWrapper/AppWrapper.tsx Outdated Show resolved Hide resolved

update: change css for string data signing input

ed02b88

refactor: remove label in incoming signing request since it is duplic…

95ecc2f

…ated

feat: peer connect redux updates

e484603

feat: add unit tests for peer connection handlers

e730449

iFergal reviewed May 31, 2024

View reviewed changes

src/core/cardano/walletConnect/peerConnection.ts Outdated Show resolved Hide resolved

src/ui/components/AppWrapper/AppWrapper.tsx Outdated Show resolved Hide resolved

src/ui/components/AppWrapper/AppWrapper.tsx Show resolved Hide resolved

Sotatek-HocNguyena added 2 commits June 3, 2024 16:00

Merge branch 'develop' of github.com:cardano-foundation/cf-identity-w…

b2260f3

…allet into feat/hook-up-peer-connect-to-the-UI

refactor: setConnectedWallet with the dApp address

73d1e01

refactor: update the peer connections list with a prototype connection

98232be

iFergal approved these changes Jun 4, 2024

View reviewed changes

iFergal merged commit 8a86b07 into develop Jun 4, 2024
2 checks passed

iFergal deleted the feat/hook-up-peer-connect-to-the-UI branch June 4, 2024 10:37

feat: hook peer connect UI to the core #494

feat: hook peer connect UI to the core #494

Uh oh!

Conversation

Sotatek-HocNguyena commented May 27, 2024 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist before requesting a review

Issue ticket number and link

Testing & Validation

Security

Code Review

Design Review

Browser

Uh oh!

github-actions bot commented May 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 28, 2024

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

github-actions bot commented May 30, 2024

Uh oh!

github-actions bot commented May 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

Sotatek-HocNguyena commented May 27, 2024 •

edited by jira bot

Loading