feature: confirm on the first time using quickinstall

[NobodyXu]

Fixed #2213

if the quickinstall stats url has changed, it'd also require confirm

[passcod]

Hmm, two thoughts:

1. perhaps we should instead have a config file, like binstall.toml, and for now just have that single item there
2. should we allow saying no, and in this case disabling the telemetry? so the choice becomes one of:

• not asked yet
• url has changed and needs a reconfirm
• okay with telemetry
• not okay with telemetry

so maybe something like

[telemetry]
enable = true
url = "https://..."

and then we kinda need to think about / decide what happens if the user changes the url. should we respect that? or should we prompt to change it?

[NobodyXu]

Yeah I think a formal style is better, though I don't think it should be user configured?

I was thinking something like our .json manifest file

[passcod]

I don't think it should be user configured either but I think if it's text (whether that's toml or json), someone will edit it, so we should probably decide what to do in that case.

[NobodyXu]

Yeah using toml is definitely more readable than just a string

[NobodyXu]

Hello @passcod been a bit busy recently to finish this off, do you have time to work on this?

[passcod]

I'll put it on my list for this weekend

[passcod]

@NobodyXu I think I've got this in a good place

[NobodyXu]

There's a catch here: what if the new config loaded does specify a install path?

We probably want to load the config before getting cargo_root

[NobodyXu]

Suggested change

	let settings_path = args.settings.clone().unwrap_or(
	cargo_home
	.as_ref()
	.unwrap_or(&cargo_root)
	.join("binstall.toml"),
	);
	let settings_path = args.settings.as_deref().map(Cow::Borrowed).unwrap_or_else(||
	Cow::Owned(cargo_home
	.as_ref()
	.unwrap_or(&cargo_root)
	.join("binstall.toml")
	)
	);

[NobodyXu]

What even if cargo_root is set, we won't use it if cargo_root is set?

[NobodyXu]

If we ignore the error when args not set, then we might still fail at installation, e.g. the settings is occupied by a directory/special file, or no permissions

[NobodyXu]

Hmm personally I think putting it in binstalk-manifest makes more sense