Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf2_eigen dependency for PCL recorder. #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JAP3TH
Copy link

@JAP3TH JAP3TH commented Oct 24, 2022

To build carla_ros_bridge in ROS2, additionally the tf2_eigen library is required.


This change is Reviewable

@kamibo
Copy link

kamibo commented Oct 27, 2022

+1

1 similar comment
@zeidk
Copy link

zeidk commented Mar 22, 2023

+1

@johannesWen
Copy link

+1

Copy link

@oliver-schumann oliver-schumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JAP3TH)

Copy link

@oliver-schumann oliver-schumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are critical. Otherwise the build with newer ROS builds as Humble and Iron fails. We need to support these dists, especially if so little changes are necessary.

Copy link

@DaniCarias DaniCarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in Ubuntu 22.04 ROS Humble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants