Fix fromMsg missing symbol rviz plugin error #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A detailed discussion may be found here ros2/geometry2#639
FelipeGdM
force-pushed
the
fix/from_msg_undefined
branch
from
d886824 to
ab9664d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem described here #711
The solution was found after some discussion at ros2/geometry2#639
When loading the rviz plugin, the system crashes with a error translated to
It was due to the definition of
fromMsgbeing missing. This function is declared attf2_geometry_msgs/tf2_geometry_msgs.hpp, so this file is included and tf2_geometry_msgs is linked to our pluginCloses #711
This change is