-
-
Notifications
You must be signed in to change notification settings - Fork 528
Added support for 46elks:// #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 174 175 +1
Lines 22554 22660 +106
Branches 3587 3603 +16
========================================
+ Hits 22476 22582 +106
Misses 70 70
Partials 8 8
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the 46elks SMS notification service to Apprise. 46elks is a Swedish telecommunications service provider that offers SMS APIs.
Key changes:
- New plugin implementation for 46elks SMS notifications with authentication, phone number validation, and configurable sender IDs
- Comprehensive test coverage including URL parsing, edge cases, and error handling
- Updated documentation and package metadata to include 46elks in the list of supported services
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apprise/plugins/fortysixelks.py | New plugin implementation for 46elks SMS service with full notification support |
| tests/test_plugin_fortysixelks.py | Test suite covering URL formats, privacy mode, error handling, and notification behavior |
| tests/helpers/rest.py | Helper refactoring to handle False meta values more cleanly by converting to default TypeError structure |
| pyproject.toml | Added "46elks" to keywords list |
| packaging/redhat/python-apprise.spec | Added 46elks to supported services list in package description |
| README.md | Added 46elks to SMS notifications table with documentation link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
169ae38 to
4901cf3
Compare
Description:
Related issue (if applicable): #
This PR adds a new SMS notification service for 46elks. It provides a minimal, fixed-endpoint implementation that uses HTTP Basic Auth and posts to
https://api.46elks.com/a1/sms. Phone numbers are parsed and validated using Apprise’s built-in helpers, and multiple recipients are supported via path segments.46elks Notifications
46elks is a straightforward SMS provider. You authenticate with your 46elks API user and password, then send
to,message, and optionallyfrom. The plugin loops per target recipient and posts form-encoded payloads to the fixed API endpoint.Setup Instructions
46elks://URL form in Apprise to send messages.Syntax
Valid syntax is as follows:
46elks://{user}:{password}@/{from}46elks://{user}:{password}@/{from}/{to}46elks://{user}:{password}@/{from}/{to1}/{to2}/{toN}You may also use
elks://as well (instead of46elks://)! 🚀Optional query parameters:
from=sender ID or E.164 numberAliases:
to=can be used in query strings and YAML to supply recipientsExamples
46elks://user:pass@/+1555123456746elks://user:pass@/+15551234567/+46701234567?from=AcmeYAML-friendly query param:
Parameter Breakdown
Examples
Send a simple message:
Multiple recipients and a sender ID:
New Service Completion Status
apprise/plugins/fortysixelks.pypyproject.tomlupdate, add46elkstokeywords(alphabetically)README.mdtable entrypackaging/redhat/python-apprise.specupdate, add46elksto%global common_descriptionChecklist
tox -e lintandtox -e format).tox -e minimal).Testing
Anyone can help test this source code as follows: