Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support to Kotlin 2.1 #411

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

marcospereira
Copy link
Contributor

The main work needs to be done on the Gradle plugin.

This is built on top of #410.

@casid
Copy link
Owner

casid commented Jan 3, 2025

Thank you, for looking into this @marcospereira!

I've just merged #410.

If you need any help, let me know!

@marcospereira
Copy link
Contributor Author

Thanks, @casid .

I'm coming back from vacations myself, and will take a look at this later. But so far, I think there is some dependency conflict/issue breaking things for Kotlin 2.1.

@casid
Copy link
Owner

casid commented Jan 31, 2025

@marcospereira I'm currently trying to reproduce the issues locally but I am a bit lost.

This build breaks already at the maven stage, when building jte-kotlin (https://github.com/casid/jte/actions/runs/12193098684/job/34014872139?pr=411). I checked out the support-kotlin-2.1.x branch but could not reproduce the issue. I hardcoded kotlin version 2.1.0, because for some reason the activation profile gave me class incompatability error (but different to the errors in the build).

Would it help with complexity, if we say Kotlin 2.1 or greater will be required for the next jte release, and whatever Gradle version is compatible with that (I think 8.6)?

@checketts
Copy link
Contributor

I'm supportive of making Kotlin 2.1 a requirement if it is needed to move forward.

@checketts
Copy link
Contributor

@casid What can I do to help with this PR? Your last comment seems to say the build works for you. Do you need me to build it locally and test it against my projects? Is there a RC candidate I could pull into my project?

@casid
Copy link
Owner

casid commented Feb 27, 2025

@checketts sorry for the late reply, I currently don't have much time for open source projects.

I just tagged you in this PR, can have a look if this would work for you as well?

#431

@checketts
Copy link
Contributor

@casid I totally understand. I'm glad to try to lend a hand in this (though I am not particularly experienced with plugins etc). Testing the packages from #431 worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants