-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add support to Kotlin 2.1 #411
base: main
Are you sure you want to change the base?
WIP: Add support to Kotlin 2.1 #411
Conversation
It will then be easier to add new profiles as more versions of kotlin are supported. This also creates dependencies between jobs to only execute codecoverage when tests are successful.
Thank you, for looking into this @marcospereira! I've just merged #410. If you need any help, let me know! |
Thanks, @casid . I'm coming back from vacations myself, and will take a look at this later. But so far, I think there is some dependency conflict/issue breaking things for Kotlin 2.1. |
@marcospereira I'm currently trying to reproduce the issues locally but I am a bit lost. This build breaks already at the maven stage, when building jte-kotlin (https://github.com/casid/jte/actions/runs/12193098684/job/34014872139?pr=411). I checked out the support-kotlin-2.1.x branch but could not reproduce the issue. I hardcoded kotlin version 2.1.0, because for some reason the activation profile gave me class incompatability error (but different to the errors in the build). Would it help with complexity, if we say Kotlin 2.1 or greater will be required for the next jte release, and whatever Gradle version is compatible with that (I think 8.6)? |
I'm supportive of making Kotlin 2.1 a requirement if it is needed to move forward. |
@casid What can I do to help with this PR? Your last comment seems to say the build works for you. Do you need me to build it locally and test it against my projects? Is there a RC candidate I could pull into my project? |
@checketts sorry for the late reply, I currently don't have much time for open source projects. I just tagged you in this PR, can have a look if this would work for you as well? |
The main work needs to be done on the Gradle plugin.
This is built on top of #410.