[blocker] Less-rigorous assertions merging assignment attribute of parameter pins#1088
Closed
apiology wants to merge 58 commits intocastwide:masterfrom
Closed
[blocker] Less-rigorous assertions merging assignment attribute of parameter pins#1088apiology wants to merge 58 commits intocastwide:masterfrom
apiology wants to merge 58 commits intocastwide:masterfrom
Conversation
To avoid merge conflicts and contributors having to deal with non-intuitive RuboCop todo changes: * Lock down development versions of RuboCop and plugins so that unrelated PRs aren't affected by newly implemented RuboCop rules. * Exclude rule entirely if more than 5 files violate it today, so that PRs are less likely to cause todo file changes unless they are specifically targeted at cleanup. * Clarify guidance on RuboCop todo file in CI error message. * Fix to hopefully ensure guidance always appears in CI error message.
Default values don't exist in RBS; it just tells you if the arg is optinal or not - this was a problem in solargraph-rails specs while assertions were on.
apiology
changed the title
apiology
commented
Dec 31, 2025
|
|
||
| def combine_with(other, attrs={}) | ||
| new_attrs = { | ||
| assignment: assert_same(other, :assignment), |
Contributor
Author
There was a problem hiding this comment.
This was redundant with BaseVariable - let's centralize the logic instead of changing two places
Contributor
Author
|
Merged into v0.59 release branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default values don't exist in RBS; it just tells you if the arg is optional or not - this created a problem in solargraph-rails specs while assertions were on, as we asserted that the default value was the same between the two pins being merged.
Blocks:
Includes for convenience: