Use presence information to improve local variable type probing #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Pin::LocalVariable#combine_with to merge information from multiple assignments to the same local variable that may be visible from a given location. * Offer a single pin with consolidated information with ApiMap#var_at_location * fix: Ensure Pin::Base#reset_generated! gets called consistently when information is invalidated. * fix: Ensure #reduce_class_type is in both ComplexType and UniqueType * fix: Track location information more consistently so that we can use it to determine visibility of assignments. * fix: Handle a number of Pin::Block rebinding cases more consistently so that we can rely on the closure information inside to determine visibility of assignments. * Improve some Pin::Base#inspect representations for easier debugging.
…-specs' into local_variable_probiing
This change matches the change in lekemula/solargraph-rspec#27 that now requires use of the appraisal gem to run soalrgraph-rspec's specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes for better testing: