-
Notifications
You must be signed in to change notification settings - Fork 340
feat(lua)!: add more bindings #7365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
usagirei
wants to merge
58
commits into
cataclysmbnteam:main
Choose a base branch
from
usagirei:lua
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,313
−856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gister it with lua
expose Islot types to lua
…oes, and what iuse_explosion expects to trigger. expose set_charges to lua
…n_action is triggered. expose it to lua
add get_item_at_with, get_items_in_radius, get_items_in_radius_with to map
…am#7362) 1. it's highly annoying 2. there's already too much missing parentheses 3. not much benefit in fixing them all taking the huge diff toll
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
* update bindings
add bindings to add item to creature add bindings to detached_ptr
add index / lenght operator to item_stack
10 tasks
|
Can I request the lua binding when it's time for an NPC to take their turn so we can implement LUA NPC intelligence :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
game.iuse_functions[...] = ...now accepts a table with 3 functions:use,can_use,tick,reset_countdownmethod for itemuseand/ortick, andcountdown_actionactor to have the item call a lua method periodically without using on_every_x hook while active (e.g viaitem:activate())get_items_in_radius,create_item_atadd_item,create_itemspawnItypeRawfields (viaItypeId:obj()) /Islot*objects:Describe the solution (The How)
N/A
Describe alternatives you've considered
N/A
Testing
N/A
Additional context
WIP, will include example lua mod using new features
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.deno task docs:genso the Lua API documentation is updated.