Skip to content

Conversation

@WishDuck
Copy link
Collaborator

@WishDuck WishDuck commented Oct 18, 2025

Purpose of change (The Why)

if wishduck could just let us use all the use actions we could delete the ET

100% needed since equip swapping between a fake tool and your weapon is pretty bad for quality of life I think, Players would be very happy.

I hope this is true

let the wishduck cook, its his funeral if it leads him to insanity

Needed to prove this wrong

Describe the solution (The How)

Adds a new section to the use menu, witch is bionic items
You can use them :)

Describe alternatives you've considered

None

Testing

Spawn in the integrated toolset bionic
Open the use menu it's there
Use it
Skip through all the errors
You can now use it

Additional context

Fixing the errors might be my funeral
I don't believed powered bionics function currently

2025-10-20-181146_1920x1080_scrot

Checklist

Mandatory

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Oct 18, 2025
@WishDuck WishDuck marked this pull request as ready for review October 21, 2025 01:08
"sort_rank": -200
},
{
"id": "BIONICS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the display, it's how it is labeled in the menu
See the above 2 for the armor and weapons categories which serve the same purpose

Copy link
Collaborator Author

@WishDuck WishDuck Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const item_category bio_cat( "BIONICS", no_translation( "BIONICS" ), 0 );
This uses it I believe

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes:

  1. Random insertion to item category file for no apparent reason?
  2. We can probably now move the use actions extended toolset has onto the toolset item and set IT to no longer include extended toolset as a sub-bionic now that it's usable from the use action menu.
  3. That said uh...the menu is pretty fugly:
image

And then uh. OH. Using the extended toolset's repair action then hitting "back to item selection" exploded game:
image

void avatar_action::use_item( avatar &you, item *loc )
{

temp_item_location *bio_tool_spot = new temp_item_location( );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
temp_item_location *bio_tool_spot = new temp_item_location( );
auto *bio_tool_spot = new temp_item_location( );

duplicate types are duplicate

@WishDuck WishDuck mentioned this pull request Oct 21, 2025
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSON related to game datas in JSON format. src changes related to source code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants