Skip to content

Restore delete_deposition method, update AEO doi, sort FERC taxonomies #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Sep 3, 2024

Overview

First part of changes for #418.

What did you change in this PR?

  • Fixes AEO archiver due to return of delete DOI error (see Publish September 1st 2024 archives #412, Publish August 1st 2024 archives #398).
  • Sorts FERC taxonomies to try and avoid changes in sorting marked as partition updates
  • Returns delete_deposition method and adds it as default to small runs of the archiver. Leave the draft for CEMS and other future big runner archives, as it's a long and slow run. Add this method to the integration tests.

Testing

How did you make sure this worked? How can a reviewer verify this?
Run an archive with no changes and with/without --clobber-unchanged (e.g. epacamd_eia). Should delete a draft when clobbering, and should leave a draft when not clobbering.

To-do list

- [x] Update relevant documentation - like comments, docstrings, README, release notes, etc.
- [x] Review the PR yourself and call out any questions or issues you have

@e-belfer e-belfer added the automation Issues relating to automated archiver runs label Sep 3, 2024
@e-belfer e-belfer self-assigned this Sep 3, 2024
@e-belfer e-belfer requested a review from zschira September 3, 2024 15:50
Copy link
Member

@zschira zschira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry got distracted with CCAI, looks good though!

@e-belfer e-belfer merged commit 0415c19 into main Sep 9, 2024
3 checks passed
@e-belfer e-belfer deleted the sept-archive-updates branch September 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issues relating to automated archiver runs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants