Make it possible to add non-PUDL data sources and metadata to the archiver #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zschira
reviewed
Jan 8, 2025
src/pudl_archiver/frictionless.py
Outdated
| """Create a datapackage for sources that won't end up in PUDL.""" | ||
| # TODO: This is a slightly ugly workaround to avoid having to add sources into | ||
| # the from_id method - should I just fix this at the source? | ||
| data_source = DataSource( |
There was a problem hiding this comment.
I think if you change this to call from_id instead of dict_from_id, that should fix the broken tests.
There was a problem hiding this comment.
Whoops, I see now that from_id doesn't take the sources dict right now. It's a bit of a pain to have to do another PUDL PR, but I think the most consistent API would be to add sources to the from_id method, since you're basically just copying what from_id does here.
zschira
requested changes
Jan 9, 2025
zschira
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A lightweight temporary solution to #499.
What problem does this address?
In concert with catalyst-cooperative/pudl#4003, makes it possible to add non-PUDL metadata sources to the archiver directly.
What did you change in this PR?
metadatafolder that replicates the one in the PUDL repository, but only contains information about data sources that aren't integrated into PUDL (currently only MECS).from_non_pudl_metadata()method in theDataPackageclass which calls theNON_PUDL_SOURCESdictionary (should work after the PR in the PUDL repository merges to make this possible).READMEmecstoeiamecsto make it more consistent with our other data sourcessources.pyin preparation for the hackathon, while I was at it!Testing
How did you make sure this worked? How can a reviewer verify this?
pudl_archiver --dataset eiamecs --sandbox --initializeTo-do list
Tasks