Add model/table-level macro for group_mean_continuity_check #4116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - Test macro for group_mean_continuity_test - Example usage in _core_eia923__cooling_system_information - Documentation in macros/schema.yml
krivard
commented
Mar 6, 2025
| @@ -0,0 +1,28 @@ | |||
| version: 2 | |||
There was a problem hiding this comment.
This is apparently the recommended way to document macros?
krivard
added
dbt
|
See my comment here |
|
Dropping in favor of #4092! |
krivard
deleted the
krivard/dbt-migrations_group_mean_continuity_modeltest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate implementation of #4092. Would contribute to completion of #4095.
Where #4092 implements this check at the column level, this PR implements it at the model/table level, which significantly reduces the amount of duplicated information in the
schema.ymlfiles that use it... at the possible expense of having to build a pretty complicated query.Overview
Three tables require a
group_mean_continuity_check, which does the following:This PR contains a draft for a possible implementation.
What did you change?
group_mean_continuity_check(ordered_group_column, thresholds, n_outliers_allowed)_core_eia923__cooling_system_information, using columns and thresholds fromtransform/eia923.py