Update row count expectations with clobber after nightly build. #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
added
testing
zaneselvans
added
dbt
zaneselvans
commented
Jun 24, 2025
| FROM mambaorg/micromamba:2.1.1-ubuntu24.04 | ||
| FROM mambaorg/micromamba:2.3.0-ubuntu24.04 |
There was a problem hiding this comment.
Incidental update -- just noticed it was stale when I was poking around in the nightly build script.
Comment on lines
+257
to
+259
| # Generate new row counts for all tables in the PUDL database | ||
| dbt_helper update-tables --clobber --row-counts all 2>&1 | tee -a "$LOGFILE" | ||
|
|
There was a problem hiding this comment.
Has to run AFTER the ETL and not in the midst of it otherwise the ETL will check against the wrong set of row counts.
e-belfer
approved these changes
Jun 24, 2025
github-project-automation
bot
moved this from In review
to Done
in Catalyst Megaproject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After the Google Batch ETL is finished, use
dbt_helperto update row count expectations, so we can save them to builds.catalyst.coop and apply them to the branch, w/o needing to run the ETL locally or worrying about something being stale.Tried to do this in #4341 but it only looked like it worked because I tested it by removing a line from the row count CSV -- it won't update existing row counts without
--clobber.I ran a branch deployment off of the the 88888/99999 PR branch #4291 with this PR #4345 and it updated the row counts for a bunch of different tables/partitions.