-
-
Notifications
You must be signed in to change notification settings - Fork 128
Add cites from July newsletter #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I continue to be unreasonably surprised by every piece of evidence that people are using our data. |
docs/catalyst_cites.bib
Outdated
year = {2025}, | ||
doi = {10.1086/734779}, | ||
URL = {https://doi.org/10.1086/734779}, | ||
eprint = {https://doi.org/10.1086/734779}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The eprint field seems to be generating a bad link:
arXiv:https://doi.org/10.1086/734779
And actually ctrl-F-ing through the bibliography I see that there are a lot of other bad arXiv links too (and a few good ones)
docs/catalyst_cites.bib
Outdated
pages = {107475}, | ||
year = {2025}, | ||
issn = {1040-6190}, | ||
doi = {https://doi.org/10.1016/j.tej.2025.107475}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the DOI field needs to be just the bare DOI, rather than a URL -- this is producing:
doi:https://doi.org/10.1016/j.tej.2025.107475
as it tries to construct a DOI URL itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I went ahead and fixed the DOI / eprint formatting issues I saw across both of our external citation .bib files
- Also added docs/**.bib to the list of file patterns for which changes don't trigger the integration tests in the merge queue.
Huh. @jdangerx I tried to add the Oh. Lol. I guess it's running the integration tests because I edited the |
Overview
What did you change?
Three new papers cite us! Wildfires, enforcement, and "passing the savings onto not our customers, no"