Skip to content

Add cites from July newsletter #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 22, 2025
Merged

Add cites from July newsletter #4447

merged 9 commits into from
Jul 22, 2025

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Jul 18, 2025

Overview

What did you change?

Three new papers cite us! Wildfires, enforcement, and "passing the savings onto not our customers, no"

@zaneselvans
Copy link
Member

I continue to be unreasonably surprised by every piece of evidence that people are using our data.

@krivard krivard marked this pull request as ready for review July 21, 2025 21:43
year = {2025},
doi = {10.1086/734779},
URL = {https://doi.org/10.1086/734779},
eprint = {https://doi.org/10.1086/734779},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eprint field seems to be generating a bad link:

arXiv:https://doi.org/10.1086/734779

And actually ctrl-F-ing through the bibliography I see that there are a lot of other bad arXiv links too (and a few good ones)

pages = {107475},
year = {2025},
issn = {1040-6190},
doi = {https://doi.org/10.1016/j.tej.2025.107475},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the DOI field needs to be just the bare DOI, rather than a URL -- this is producing:

doi:https://doi.org/10.1016/j.tej.2025.107475

as it tries to construct a DOI URL itself.

Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I went ahead and fixed the DOI / eprint formatting issues I saw across both of our external citation .bib files
  • Also added docs/**.bib to the list of file patterns for which changes don't trigger the integration tests in the merge queue.

@zaneselvans zaneselvans added the docs Documentation for users and contributors. label Jul 22, 2025
@zaneselvans zaneselvans moved this from New to In review in Catalyst Megaproject Jul 22, 2025
@zaneselvans zaneselvans enabled auto-merge July 22, 2025 21:06
@zaneselvans zaneselvans added this pull request to the merge queue Jul 22, 2025
@zaneselvans
Copy link
Member

zaneselvans commented Jul 22, 2025

Huh. @jdangerx I tried to add the .bib files to the list of files that can be changed without triggering the integration tests in the merge queue, but it still seems to be running the integration tests.

Oh. Lol. I guess it's running the integration tests because I edited the pytest.yml file to add docs/**.bib so it would ignore them. Next time!

Merged via the queue into main with commit 701a0d5 Jul 22, 2025
18 checks passed
@zaneselvans zaneselvans deleted the update-cites-jul2025 branch July 22, 2025 22:26
@github-project-automation github-project-automation bot moved this from In review to Done in Catalyst Megaproject Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation for users and contributors.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants