Add a new setting to allow replacing name and surname instead of scrambling #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'department' => ['institution', 'department'], | ||
| 'address' => ['address', 'city', 'country', 'lang', 'calendartype', 'timezone'], | ||
| ]; | ||
| self::replace_first_and_last_names(); |
There was a problem hiding this comment.
Should this be all or nothing? ie we either scramble all the names, OR we replace all the names. We don't want to do both? The scrambling is mildly expensive so we don't want to replace them and then needlessly scramble them again
Some unit tests would be good too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes scrambling names is not enough.
A new setting was added to allow replacing first and last names in mdl_user table instead of scrambling all names. It replaces all names using a prefixes and user id. It doesn't modify users with usernames mentioned in keepusernames setting.