feat: Add notification pathway for aborted flows #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peterburnett
force-pushed
the
abort-notify
branch
from
a1f1e37
to
78c069b
Compare
keevan
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Code looks good.
Happy for this to be merged in. I checked the email functionality and it is working as expected.
One small observation which may be useful. Should the email subject contain the name of the dataflow (in addition to the abort message)?
This may help address cases where many dataflows are active, and would make identifying the problematic one quicker to e.g. to filter on, instead of filtering on the email body.
An example of this would be changing this:
Dataflow run aborted
to something like this:
Dataflow run aborted: SMS import and sync
|
This is a good idea, I'll add this |
Peterburnett
force-pushed
the
abort-notify
branch
from
78c069b
to
57c0eb8
Compare
|
Updated. Ill merge once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.