Enhance logging details and verbosity #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a test failure as well about a non matching list of params. |
Peterburnett
requested changes
Oct 14, 2024
keevan
force-pushed
the
tweak-logging
branch
4 times, most recently
from
1234567
to
1234567
Compare
- update providers to static functions - @param phpdocs - phpdocs, trait docs, static providers - remove unused use statements - remove void return type and docs - fix Throwable includes
Peterburnett
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbosity / min log level setting (per dataflow)
Log comparison:
Before:
[2024-10-10 11:08:57.219433] dataflow/12.WARNING: Log: Example log entry 1 [] []After:
[2024-10-10 11:08:57.219433] dataflow/12.WARNING: Log: Example log entry 1 {"first":"1","second":"2","third":"3"} []Example test dataflow:
log_testing_20241010_0254.yml.txt