-
Notifications
You must be signed in to change notification settings - Fork 28
Use PEP 735 dependency groups #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. I have a few requests/suggestions:
- Can you update the copilot-setup-steps.yml workflow as well?
- The "Testing Suite" page in the Developer Guide section of the docs needs to be updated
- The "Building the Documentation" page in the Developer Guide section of the docs needs to be updated
Thanks for catching those. It should be updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 145 145
Lines 9515 9515
=======================================
Hits 8281 8281
Misses 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This should fix issue #1366.
I’ve been encountering dependency issues when trying to install neuroconv and solve the full installation. The problem is that the documentation dependencies are pinned to very specific versions (as they probably should be for reproducibility of the documentation style), but since they’re defined as extras, the package manager tries to resolve them and fails.
Fortunately, PEP 735 offers a clear solution by excluding these from the extras as dependency groups.
More concretely, this change reorganizes the testing, documentation, and development dependencies from [project.optional-dependencies] format into the new standardized [dependency-groups] section. Specifically, the test, docs, and dev (including pre-commit) dependencies are now defined as dependency groups, while domain-specific extras like ecephys, ophys, and behavior remain as extras dependencies.