Skip to content

Use PEP 735 dependency groups #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged

Use PEP 735 dependency groups #1434

merged 5 commits into from
Jul 16, 2025

Conversation

h-mayorquin
Copy link
Collaborator

This should fix issue #1366.

I’ve been encountering dependency issues when trying to install neuroconv and solve the full installation. The problem is that the documentation dependencies are pinned to very specific versions (as they probably should be for reproducibility of the documentation style), but since they’re defined as extras, the package manager tries to resolve them and fails.

Fortunately, PEP 735 offers a clear solution by excluding these from the extras as dependency groups.

More concretely, this change reorganizes the testing, documentation, and development dependencies from [project.optional-dependencies] format into the new standardized [dependency-groups] section. Specifically, the test, docs, and dev (including pre-commit) dependencies are now defined as dependency groups, while domain-specific extras like ecephys, ophys, and behavior remain as extras dependencies.

@h-mayorquin h-mayorquin marked this pull request as ready for review July 15, 2025 23:20
@h-mayorquin h-mayorquin requested a review from pauladkisson July 15, 2025 23:54
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I have a few requests/suggestions:

  • Can you update the copilot-setup-steps.yml workflow as well?
  • The "Testing Suite" page in the Developer Guide section of the docs needs to be updated
  • The "Building the Documentation" page in the Developer Guide section of the docs needs to be updated

@h-mayorquin
Copy link
Collaborator Author

Overall looks great. I have a few requests/suggestions:

  • Can you update the copilot-setup-steps.yml workflow as well?
  • The "Testing Suite" page in the Developer Guide section of the docs needs to be updated
  • The "Building the Documentation" page in the Developer Guide section of the docs needs to be updated

Thanks for catching those. It should be updated now.

Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@h-mayorquin h-mayorquin enabled auto-merge (squash) July 16, 2025 17:05
@h-mayorquin h-mayorquin merged commit 9966fb8 into main Jul 16, 2025
25 checks passed
@h-mayorquin h-mayorquin deleted the use_dependency_groups branch July 16, 2025 17:49
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (e1ca0c4) to head (60a7097).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files         145      145           
  Lines        9515     9515           
=======================================
  Hits         8281     8281           
  Misses       1234     1234           
Flag Coverage Δ
unittests 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dependency groups for testing dependencies
2 participants