Skip to content

Add metadata key to ImageInterface #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged

Conversation

h-mayorquin
Copy link
Collaborator

A movement in the direction of #269 that will allow adding more than one container.

@h-mayorquin h-mayorquin self-assigned this Jul 17, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review July 17, 2025 22:10
@h-mayorquin h-mayorquin requested a review from pauladkisson July 17, 2025 22:33
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a very small note about future warning vs deprecation warning. Otherwise, looks great.

@h-mayorquin h-mayorquin enabled auto-merge (squash) July 18, 2025 17:31
@h-mayorquin h-mayorquin merged commit ffc4f1f into main Jul 18, 2025
24 checks passed
@h-mayorquin h-mayorquin deleted the improve_image_interface branch July 18, 2025 18:37
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (b8afb7a) to head (91ee665).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/neuroconv/datainterfaces/image/imageinterface.py 84.61% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
- Coverage   87.14%   87.14%   -0.01%     
==========================================
  Files         145      145              
  Lines        9623     9635      +12     
==========================================
+ Hits         8386     8396      +10     
- Misses       1237     1239       +2     
Flag Coverage Δ
unittests 87.14% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/datainterfaces/image/imageinterface.py 89.60% <84.61%> (-0.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants