-
Notifications
You must be signed in to change notification settings - Fork 28
Added per-image metadata support to ImageInterface
#1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata structure and tests look great! Can you add an updated example to the entry for image in the conversion gallery?
Yes, good idea. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @h-mayorquin!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
+ Coverage 87.14% 87.15% +0.01%
==========================================
Files 145 145
Lines 9635 9643 +8
==========================================
+ Hits 8396 8404 +8
Misses 1239 1239
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This will allow users to specify individual
resolution
(pixels/cm), name anddescription
for each image through metadata structure.