Skip to content

Added per-image metadata support to ImageInterface #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2025

Conversation

h-mayorquin
Copy link
Collaborator

This will allow users to specify individual resolution (pixels/cm), name and description for each image through metadata structure.

@h-mayorquin h-mayorquin self-assigned this Jul 18, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review July 18, 2025 19:38
@h-mayorquin h-mayorquin requested a review from pauladkisson July 18, 2025 21:40
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata structure and tests look great! Can you add an updated example to the entry for image in the conversion gallery?

@h-mayorquin
Copy link
Collaborator Author

Metadata structure and tests look great! Can you add an updated example to the entry for image in the conversion gallery?

Yes, good idea.

@h-mayorquin
Copy link
Collaborator Author

Metadata structure and tests look great! Can you add an updated example to the entry for image in the conversion gallery?

Done.

Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @h-mayorquin!

@h-mayorquin h-mayorquin merged commit 0111282 into main Jul 21, 2025
24 checks passed
@h-mayorquin h-mayorquin deleted the improve_image_interface_metadata branch July 21, 2025 15:41
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (ffc4f1f) to head (df98673).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   87.14%   87.15%   +0.01%     
==========================================
  Files         145      145              
  Lines        9635     9643       +8     
==========================================
+ Hits         8396     8404       +8     
  Misses       1239     1239              
Flag Coverage Δ
unittests 87.15% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/datainterfaces/image/imageinterface.py 90.22% <100.00%> (+0.62%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants