Skip to content

Removal of deprecated directory and file types #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Conversation

h-mayorquin
Copy link
Collaborator

The time has come and now handle this with Pydantic.

@h-mayorquin h-mayorquin self-assigned this Jul 20, 2025
@h-mayorquin h-mayorquin marked this pull request as ready for review July 21, 2025 14:13
@h-mayorquin h-mayorquin requested a review from pauladkisson July 21, 2025 15:42
@h-mayorquin h-mayorquin enabled auto-merge (squash) July 21, 2025 16:09
@h-mayorquin h-mayorquin merged commit 435c96e into main Jul 21, 2025
43 of 45 checks passed
@h-mayorquin h-mayorquin deleted the remove_some_warnings branch July 21, 2025 18:48
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.22%. Comparing base (ffc4f1f) to head (08f785c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   87.14%   87.22%   +0.08%     
==========================================
  Files         145      145              
  Lines        9635     9625      -10     
==========================================
- Hits         8396     8395       -1     
+ Misses       1239     1230       -9     
Flag Coverage Δ
unittests 87.22% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rfaces/ecephys/neuralynx/neuralynxdatainterface.py 85.89% <ø> (ø)
...tainterfaces/ecephys/openephys/_openephys_utils.py 90.00% <ø> (ø)
.../ecephys/openephys/openephysbinarydatainterface.py 97.43% <ø> (ø)
.../ecephys/openephys/openephyslegacydatainterface.py 97.72% <ø> (ø)
...terfaces/ophys/femtonics/femtonicsdatainterface.py 88.07% <100.00%> (+0.07%) ⬆️
.../micromanagertiff/micromanagertiffdatainterface.py 100.00% <ø> (ø)
...tainterfaces/ophys/miniscope/miniscopeconverter.py 90.62% <ø> (ø)
src/neuroconv/tools/data_transfers/_globus.py 100.00% <ø> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 91.32% <100.00%> (ø)
...on_specification/_yaml_conversion_specification.py 88.76% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants