Skip to content

Conversation

@h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Oct 1, 2025

This PR uses the configuration file of the miniscope system to automate the path discovery of the MiniscopeConverter.

This PR should come after #1524 and has that PR as its base.

The configuration file was introduced on the stable version of the DAQ:
https://github.com/Aharoni-Lab/Miniscope-DAQ-QT-Software/releases

A description of them with examples and be found here:
https://github.com/Aharoni-Lab/Miniscope-DAQ-QT-Software/wiki/User-Configuration-Files

They capture the folder structure of the experiment, see discussion here:
catalystneuro/roiextractors#356

We can use this, when available, to automate the folder path discovery for users and simplify their conversions.

This will need:
catalystneuro/roiextractors#509

Meanwhile, I will be explicitly settings the timestamps here.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 90.10989% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.98%. Comparing base (cb3bb79) to head (e76777c).

Files with missing lines Patch % Lines
...tainterfaces/ophys/miniscope/miniscopeconverter.py 90.07% 27 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   88.95%   88.98%   +0.03%     
==========================================
  Files         156      156              
  Lines       10825    11082     +257     
==========================================
+ Hits         9629     9861     +232     
- Misses       1196     1221      +25     
Flag Coverage Δ
unittests 88.98% <90.10%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/ophys/miniscope/miniscopeimagingdatainterface.py 92.36% <100.00%> (+0.05%) ⬆️
...tainterfaces/ophys/miniscope/miniscopeconverter.py 89.61% <90.07%> (-1.29%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants