Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust implementation #292

Open
wants to merge 72 commits into
base: master
Choose a base branch
from

Conversation

Romira915
Copy link

  • Add Rust implementation.
  • Only docker-compose

@catatsuy
Copy link
Owner

It is difficult for me to maintain the Rust implementation. Sorry. But I would suggest the following.

  • You publish your Rust implementation in your repository and I will link to it from the README of this repository.
  • Let me know when you are ready. I will post the link.

And I have something to tell you. Actually, Ruby implementation is the original implementation and Go implementation is ported from Ruby implementation. Some parts of the implementation are changed for Go's convenience.

`printf "%s" #{Shellwords.shellescape(src)} | openssl dgst -sha512 | sed 's/^.*= //'`.strip

out, err := exec.Command("/bin/bash", "-c", `printf "%s" `+escapeshellarg(src)+` | openssl dgst -sha512 | sed 's/^.*= //'`).Output()

Probably, you should use duct::sh instead of duct::cmd. Thanks. @Romira915

@Romira915
Copy link
Author

Thank you for the suggestion. Suggestion accepted and fixed.
And it's ready to go. Here is my repository.

@catatsuy
Copy link
Owner

@Romira915 I think you should have a repository for only Rust applications such as the following repository.

https://github.com/methane/pixiv-isucon2016-python

Because it is difficult for people who actually want to use your code to use it if it is forked.

@Romira915
Copy link
Author

I Understood. Accordingly I have created a rust only repository.

https://github.com/Romira915/private-isu-rust

Thank you. @catatsuy

catatsuy added a commit that referenced this pull request Jun 20, 2022
catatsuy added a commit that referenced this pull request Jun 20, 2022
@catatsuy
Copy link
Owner

Thank you. I added your repository on README. @Romira915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants