Skip to content

Use variable templates instead of structs for traits #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

ZXShady
Copy link
Contributor

@ZXShady ZXShady commented Apr 17, 2025

Variable templates are simpler for the compiler and just better to read and write.

Note i did not change is_range to variable template since it is part of public API therefore this is an API break.

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (dde8220) to head (484c359).
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2975   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         198      198           
  Lines        8599     8599           
=======================================
  Hits         7823     7823           
  Misses        776      776           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@horenmar horenmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but the new variables should follow the stdlib convention of using _v suffix for constexpr bool variables.

@ZXShady ZXShady force-pushed the use_variable_templates branch from 4ea97b5 to 5dca28a Compare April 25, 2025 06:34
@ChrisThrasher ChrisThrasher force-pushed the use_variable_templates branch from 5dca28a to 40fc464 Compare April 27, 2025 00:27
@ZXShady ZXShady force-pushed the use_variable_templates branch 2 times, most recently from 517d5f0 to a6785d3 Compare April 27, 2025 19:06
@ChrisThrasher ChrisThrasher force-pushed the use_variable_templates branch from a6785d3 to 484c359 Compare April 28, 2025 01:18
@ChrisThrasher ChrisThrasher merged commit 4ff57ab into catchorg:devel Apr 28, 2025
96 checks passed
@ZXShady ZXShady deleted the use_variable_templates branch May 21, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants