fix: make deleted member function public #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2988 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 198 198
Lines 8599 8599
=======================================
Hits 7823 7823
Misses 776 776 🚀 New features to boost your workflow:
|
e-kwsm
force-pushed
the
modernize-use-equals-delete
branch
from
fc826f6 to
6665cc1
Compare
ChrisThrasher
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch2/.clang-tidy
Line 21 in 3013cb8
modernize-use-equals-delete is enabled and the code complies with it, but clang-tidy issues warning: "deleted member function should be public."