Allow using only types in TEMPLATE_TEST_CASE_SIG.
#2995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `TEMPLATE_TEST_CASE_SIG` fails to compile when the signature contains only types:
```
TEMPLATE_TEST_CASE_SIG(
"TemplateTestSig: compiles with two type parameters",
"[template][onlytypes]",
((typename U, typename V), U, V), (int,int)) {}
```
The trick is to resolve the ambiguity between the two overloads of
`get_wrapper` (`TypeList` and `Nttp`) by making one match more strongly.
We also need to allow `reg_test` to register more than one type.
Add unit tests.
Fixes catchorg#2680
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2995 +/- ##
==========================================
- Coverage 91.14% 90.99% -0.16%
==========================================
Files 198 198
Lines 8514 8609 +95
==========================================
+ Hits 7760 7833 +73
- Misses 754 776 +22 🚀 New features to boost your workflow:
|
|
Thanks. I made small changes for the tests to pass and to avoid polluting the global namespace with the priority tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
TEMPLATE_TEST_CASE_SIGfails to compile when the signature contains only types:The trick is to resolve the ambiguity between the two overloads of
get_wrapper(TypeListandNttp) by making one match more strongly. We also need to allowreg_testto register more than one type.Add unit tests.
Fixes #2680