Skip to content

fixing apple silicon ci issues #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catdad merged 4 commits into from
Apr 28, 2024
Merged

fixing apple silicon ci issues #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
615d47b
not using macos for older versions of node
catdad Apr 28, 2024
3ab4076
using older version of retry cli
catdad Apr 28, 2024
2303ea7
allow getting electron version to fail I guess
catdad Apr 28, 2024
9211377
skip electron 20 on macos
catdad Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ jobs:
os: [macos-latest, windows-latest, ubuntu-latest]
node: [16, 18]
electron: [23, 20]
exclude:
# older electron seems to misbehave on apple silicon
- os: macos-latest
electron: 20
include:
- os: ubuntu-latest
node: 14
Expand All @@ -25,13 +29,13 @@ jobs:
- os: windows-latest
node: 14
electron: 14
- os: macos-latest
- os: ubuntu-latest
node: 14
electron: 12
- os: windows-latest
node: 12
electron: 10
- os: macos-latest
- os: ubuntu-latest
node: 10
electron: 8
runs-on: ${{ matrix.os }}
Expand All @@ -46,7 +50,7 @@ jobs:
- run: npm install
- run: npm install electron@${{ matrix.electron }}
- run: node --version
- run: npx electron --version
- run: npx electron --version || echo well that went poorly
- name: npm test
run: npm run citest

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"fs-extra": "^8.1.0",
"mocha": "^6.2.2",
"node-stream": "^1.7.0",
"retry-cli": "^0.7.0",
"retry-cli": "0.6.0",
"symlink-dir": "^3.1.1",
"unstyle": "^0.1.0",
"xvfb-maybe": "^0.2.1"
Expand Down