fix(duckduckgo.com): misc #1713
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncenter
reviewed
Apr 19, 2025
uncenter
reviewed
Apr 19, 2025
| @@ -1237,7 +1236,7 @@ | |||
| --theme-button-primary-bg: @blue !important; | |||
| --theme-searchbox-caret-bg: @accent !important; | |||
|
|
|||
| .home_root___gvmE { | |||
| body div div { | |||
There was a problem hiding this comment.
This is better, but are there no other identifying attributes we can use for this second div here?
uncenter
requested changes
May 1, 2025
Comment on lines
+1312
to
+1313
| color-scheme: if(@flavor = latte, light, dark); | ||
|
|
There was a problem hiding this comment.
Suggested change
| color-scheme: if(@flavor = latte, light, dark); |
The previous @-moz-document already covers this and the rest of the default styles, can be removed.
| @@ -203,6 +208,13 @@ | |||
| border-color: @surface0; | |||
| } | |||
|
|
|||
| main { | |||
| --theme-howitworks-downloads-bg: @surface0 !important; | |||
| --theme-bg-cta-cards: @surface0 !important; | |||
| main { | ||
| --theme-howitworks-downloads-bg: @surface0 !important; | ||
| --theme-bg-cta-cards: @surface0 !important; | ||
| --theme-bg-home: @base !important; |
There was a problem hiding this comment.
Already set under #__next div on line 1240?
| --theme-howitworks-downloads-bg: @surface0 !important; | ||
| --theme-bg-cta-cards: @surface0 !important; | ||
| --theme-bg-home: @base !important; | ||
| --theme-bg-home-searchbox: @surface0 !important; |
There was a problem hiding this comment.
Already set under #__next div on line 1243?
uncenter
changed the title
uncenter
added
the
waiting on author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 What does this fix? 🔧
Fixes unthemed elements on duckduckgo.com, start.duckduckgo.com, duck.ai, and html.duckduckgo.com.
Closes #1514
🗒 Checklist 🗒