Skip to content

fix(canvas-lms): buttons & misc #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 5, 2025
Merged

Conversation

pynappo
Copy link
Contributor

@pynappo pynappo commented May 3, 2025

🔧 What does this fix? 🔧

  • Reorganizes button styling to not rely on autogenerated classnames as much
    • Mixins are used for easier organization
    • Some buttons that became unstyled with recent canvas css changes will now stay styled (hopefully)
    • Many buttons now look better/react properly to hover (modals, inbox, discussions, etc)
  • Revises tooltip styling
  • Styles the new file upload component on assignment submission
  • misc:
    • Tooltip arrows are the proper color
    • Checkboxes are styled
    • Some icons are fixed

(It's pretty late for me but if preview screenshots are wanted, or if this PR should be split into pieces, I can do that later)

another thing to resolve: how should outlines on focused buttons/links/etc like these be colored:

image

image

in canvas I think they just use blue for everything. since in this userstyle we have the extra accent color i'm not sure whether to use only @blue or only @accent.

🗒 Checklist 🗒

@github-actions github-actions bot added the canvas-lms Canvas LMS label May 3, 2025
@uncenter uncenter changed the title fix(canvas-lms): revise button styles and misc. fixes fix(canvas-lms): buttons & misc May 4, 2025
@pynappo pynappo merged commit 44ef30c into catppuccin:main May 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas-lms Canvas LMS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants