Skip to content

Conversation

@GravityCore
Copy link
Contributor

The existing rule did not work. Also changed the CMPs name from flysas to SAS.

@MidasN
Copy link
Collaborator

MidasN commented Nov 7, 2025

Thanks!
I would prefer if the rulename stays flysas(.com), because it makes it easier to trace which URL this rule is about.

I just commented on your other pull request #541 that I would prefer language filters over nth-child solutions, but in this case I think that approach is a good compromise. We know this cookie banner is custom for this website, and the site uses a lot of language localisation so implementing it to work for all would be a big task. So using relative positioning of elements in the DOM seems like the best approach here.

@GravityCore
Copy link
Contributor Author

Should its name stay so even if the main websites, sas.se, sas.dk, sas.no , use the SAS in their domain? I guess they went for flysas, as another company already registered for https://www.sas.com/nl_nl/home.html .

Yeah, luckily quite many websites follow the same order of these consent buttons, nor I have not encountered yet any that willingly change it. I would gladly select elements based on universal and semantically meaningful info-piece, if the websites offered one.

@MidasN
Copy link
Collaborator

MidasN commented Nov 9, 2025

Good point, I hadn't seen that. But yes I think flysas is still a better approach, since flysas.se, flysas.dk and flysas.no also work (just redirect to sas.se/dk/no).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants