Skip to content

php 8.2: Deprecated function mb_convert_encoding() #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

s-ayers
Copy link
Contributor

@s-ayers s-ayers commented Apr 22, 2024

@christian-kolb
Copy link

Anything we can do to get this merged and a new release published? 🙂

@heddn
Copy link

heddn commented Dec 16, 2024

I've run the tests locally and they pass green. There are some other Iterator deprecations (in tests only), but that is outside of scope of this. I also reviewed the test coverage of this module to confirm we test TableDiff::createDocumentWithHtml, there is 100% test coverage of that method. LGTM.

@heddn
Copy link

heddn commented Dec 16, 2024

BTW, we depend upon this module in Drupal (its a top 100 module) and we would really like to see this fix merged. See https://www.drupal.org/project/diff/issues/3419173

@jschroed91 jschroed91 merged commit 88f817a into caxy:master Dec 26, 2024
1 check passed
@jschroed91
Copy link
Member

Thank you for repinging on this - will get this updated

@laurisigaunis
Copy link

laurisigaunis commented Jan 15, 2025

I get error when patching

iconv(): Detected an illegal character in input string in Caxy\HtmlDiff\Table\TableDiff->createDocumentWithHtml() (line 630 of /app/vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/Table/TableDiff.php)

Adding //TRANSLIT solves issue for me.
Full line: $dom->loadHTML(htmlspecialchars_decode(iconv('UTF-8', 'ISO-8859-1//TRANSLIT', htmlentities($text, ENT_COMPAT, 'UTF-8')), ENT_QUOTES));

christian-kolb pushed a commit to vera-contracts/php-htmldiff that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants