Skip to content

Add parameter to build and run model condo workflow to run ingest on batch #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 6, 2025
Merged

Add parameter to build and run model condo workflow to run ingest on batch #114

merged 9 commits into from
Jun 6, 2025

Conversation

Damonamajor
Copy link
Contributor

Run with removing a selected feature from input

SELECT
  meta_pin, prox_nearest_hospital_dist_ft
FROM
  model.assessment_card
where run_id = '2025-06-06-relaxed-christian'
limit 10

Proof of workflow

https://us-east-1.console.aws.amazon.com/cloudwatch/home?region=us-east-1#logsV2:log-groups/log-group/%2Faws%2Fbatch%2Fjob/log-events/z_ci_add-parameter-to-build-and-run-model-condo-workflow-to-run-ingest-on-batch_ccao-data-model-condo-avm%2Fdefault%2F93432923d2ce4f88912fc688ac508a16

@Damonamajor Damonamajor self-assigned this Jun 6, 2025
@Damonamajor Damonamajor linked an issue Jun 6, 2025 that may be closed by this pull request
Add parameter to build-and-run-model condo workflow to run ingest on Batch #113
Closed
jeancochrane
jeancochrane reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we accidentally reverted the required command workflow attribute in 1c5368a. Once we add that back in, re-request my review and I'll take a quick final look before approving.

Damonamajor and others added 3 commits June 6, 2025 14:23
@Damonamajor @jeancochrane
Update Dockerfile
df733bb 
Co-authored-by: Jean Cochrane <[email protected]>
@Damonamajor
re-add command
3b5f4d9
@Damonamajor
Merge branch 'add-parameter-to-build-and-run-model-condo-workflow-to-…
28e2003 
…run-ingest-on-batch' of github.com:ccao-data/model-condo-avm into add-parameter-to-build-and-run-model-condo-workflow-to-run-ingest-on-batch
@Damonamajor Damonamajor requested a review from jeancochrane June 6, 2025 19:49
jeancochrane
jeancochrane approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@Damonamajor Damonamajor merged commit 1cc6329 into master Jun 6, 2025
5 checks passed
@Damonamajor Damonamajor deleted the add-parameter-to-build-and-run-model-condo-workflow-to-run-ingest-on-batch branch June 6, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeancochrane jeancochrane jeancochrane approved these changes

@wrridgeway wrridgeway Awaiting requested review from wrridgeway wrridgeway is a code owner

Assignees

@Damonamajor Damonamajor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameter to build-and-run-model condo workflow to run ingest on Batch
2 participants
@Damonamajor @jeancochrane