Skip to content

[feature/new-dag-editor] part 6: Other styles and utils changes to support the new DAG editor #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/new-dag-editor
Choose a base branch
from

Conversation

GnsP
Copy link
Collaborator

@GnsP GnsP commented Mar 28, 2025

Other styles and utils changes to support the new DAG editor

Description

Part 6 of the set of changes implementing the new DAG editor for CDAP UI.

Links to the previous changesets:

  1. [feature/new-dag-editor] part 1: Add changes to the dag-plus directive #1309
  2. [feature/new-dag-editor] part 2: Add back the older my-dag-ctrl to keep supporting the older ui #1312
  3. [feature/new-dag-editor] part 3: update build configs and add reactflow as dependency #1313
  4. [feature/new-dag-editor] part 4: Add the main component for the reactflow based DAG editor #1316
  5. [feature/new-dag-editor] part 5: Add components for the DAG Nodes and Edges #1317

In this PR, we add some minor css and utility changes to make the new DAG editor render correctly. We also add the capability to remove the footer from any page (though additional css changes may be required in case of some pages with rigid layouts).

This PR will be followed by one last part with fixes and updates for broken testcases.

PR Type

  • Bug Fix
  • Feature
  • Build Fix
  • Testing
  • General Improvement
  • Cherry Pick

Links

Jira: CDAP-21142

Test Plan

NA. Not testable. Tests will be run when the complete feature branch is merged to develop

Screenshots

NA

@GnsP GnsP requested review from njbriggs and radhikav1 March 28, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant