fix: reprocessing workflow bails when retry tasks are executed #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
reviewed
Dec 10, 2025
mrgrain
reviewed
Dec 10, 2025
mrgrain
approved these changes
Dec 10, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reprocessing workflow has a retry mechanism built in that retries common S3 failures with decreasing amounts of objects requested. However this retry mechanism was incorrectly chained and results in immediately ending the execution rather than going to the next task. In practice this means that the reprocessing workflow continues as normal until it hits the
DataLimitExceededs3 error, enters the retry, and subsequently ends. We are not reprocessing everything that is indexed in construct hub.The current state machine graph for the reprocess workflow is:
The changes in this PR result in:
Note that the change is that all tasks in the retry mechanism point to
Is There Moreon success.Note
Construct Hub previously used
aws-cdk-libversion 2.189.0 which was subject to this step functions regression, causing test deploys to fail. I updated to the earliest working version, 2.194.0, and also needed to update snapshot tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license