fix: npm follower occasionally drops incoming updates #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Example logs of local setup with |
kaizencc
commented
Jan 7, 2026
| // The slowest batch processing time so far (starts at 60 seconds). This is how much time should | ||
| // be left before timeout if a new batch is to be fetched. | ||
| let maxBatchProcessingTime = 30_000; | ||
| let maxBatchProcessingTime = 60_000; |
Contributor
Author
There was a problem hiding this comment.
The NPM follower function does some basic math for when to grab the next batch and when to exit and wait for a subsequent lambda execution. Because this change increases the batch time by up to 30 seconds, I have increased the expected worst-case-scenario time by 30 seconds as well.
rix0rrr
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm follower grabs information from multiple sources that can be out of sync. This subsequently causes some new package updates to not be identified and sent to ingestion.
Basically, with the new NPM API, our NPM follower ingests information from multiple sources. Occasionally there is a delay between picking up a new change from the NPM changes stream and the change actually showing up in the specific package metadata.
Previously, we would just drop this change altogether as unactionable. Subsequent updates to the package could trigger another metadata lookup that would grab the change, but this results in an indeterminate delay.
Now, we identify that the metadata is out of sync by comparing the sequential part of the
revproperty. If the metadatarevis below the changesrev, we know it is lagging behind and exponentially retry until the metadata is updated or until 30 seconds (where we then proceed with the out of sync data).The NPM follower function does some basic math for when to grab the next batch and when to exit and wait for a subsequent lambda execution. Because this change increases the batch time by up to 30 seconds, I have increased the expected worst-case-scenario time by 30 seconds as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license