Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional tenant JWT payload field (fixes #205) #420

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

kpshek
Copy link
Contributor

@kpshek kpshek commented Nov 2, 2018

Additionally, the example JWT has been improved to include the public and private keys used to both sign and verify the signature.

This fixes #205

Additionally, the example JWT has been improved to include the public and private keys used to both sign and verify the signature.
Copy link
Member

@isaacvetter isaacvetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was (naively) a bit surprised that the example tenant code was a guid. There may be implementations of this optional field that will be a more human-readable string, but I understand why this is the example.

@kpshek kpshek merged commit 7678ea7 into master Nov 7, 2018
@kpshek kpshek deleted the issue/205-add-tenant-jwt-claim branch November 7, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify that an implementation specific tenant/billing_code can be added to the JWT
3 participants