refactor: add enforce strict value for combobox #5572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://is4rxr6doxcoyg6ou34kjsh2u40kauzp.lambda-url.ca-central-1.on.aws/ |
github-actions
bot
added
the
!! Package Update !!
timarney
changed the title
dsamojlenko
reviewed
May 22, 2025
...ocale]/(form administration)/form-builder/[id]/components/dialogs/MoreDialog/StrictValue.tsx
Show resolved
Hide resolved
|
@dsamojlenko do you have an issue open for this ? |
dsamojlenko
reviewed
May 22, 2025
| const { t } = useTranslation("form-builder"); | ||
|
|
||
| // ⚠️ Early return if not combobox | ||
| if (item.type !== "combobox") { |
There was a problem hiding this comment.
could use the enum FormElementTypes.combobox
|
Related to #5010 |
7 tasks
🧪 Review environmenthttps://saxgbhsvtoh6nvfjze4aaobl2i0vuvfm.lambda-url.ca-central-1.on.aws/ |
timarney
changed the title
timarney
commented
Jun 16, 2025
| @@ -1415,6 +1415,11 @@ | |||
| }, | |||
| "en": "English", | |||
| "fr": "Français", | |||
| "strictValue": { | |||
There was a problem hiding this comment.
@anikbrazeau couple of missing strings here if you get a chance
github-actions
bot
removed
the
!! Package Update !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
See: https://cds-snc.freshdesk.com/a/tickets/22779
Currently searchable list allows a user to input arbitrary text.
For example a list of colours
If the user types
yeand doesn't "select" a value from the list provided the input will captureyeand notyellow.This update enforces that the user picks or types a full value from the list -- if they don't the typed value will clear.
See:
strict-value.mp4