Algo QC 192 #9
Open
Algo QC 192 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard copy-paste of IJK_Kernel files
Adding compilable Algo_QC with patched items that correspond to the right calculation of surfaces for the calculation of the mass flux in the QUICK and Centered order 2 schemes Correction of the Simd tools used to compute the terms of the QUICK scheme : in the J direction (spanwise in a channel), the offset to take into account in the J direction for each parallel domain was fixed when it needed to be taken into account. This had the effect of not computing the flux correctly on the very first J cell for the mass flux. This is a very similar bug to commit hash: ead456d04d72824210683fa612a7885d41a20d1e which is detailed in the changelogs of Algo_QC.
|
Note: the keyword "projection_initiale_demandee_" doesn't work atm, as I don't know what the variable "Shear_DU" corresponds to in TRUST/src/IJK/Framework/IJK_Navier_Stokes_tools.cpp: https://github.com/cea-trust-platform/trust-code/blob/master/src/IJK/Framework/IJK_Navier_Stokes_tools.cpp#L591. |
OpDiffTurbIJKScalar.cpp: Added method OpDiffVectorialIJKScalar_double::ajouter This method is used in the Algo_QC code and was missing. Its implementation is not changed from previous versions.
OpCentre2IJK.*: These files are centered order 2 scheme for velocity convection in momentum energy convervation equation. They are a copy-paste of the OpCentre4IJK.* files with g1 and g4 values put to 0.0, and g2 and g3 values put to 0.5.
|
In last two commits, added OpDiffVectorialIJKScalar_double::ajouter method. Implementation is detailed in both commits. |
Statistiques_dns_qc_ijk.*: The class Statistiques_dns_qc_ijk is just a child class of Statistiques_dns_ijk that implements the method `complemer_read' as non forcing for process exiting. This is essentially like the old version of Statistiques_dns_ijk*, where Statistiques_dns_ijk was directly used for logging statistics in Algo_QC.
OpDiffTurbIJK.tpp, OpDiffTurbIJKScalar.tpp: Bug correction relating to the variable `dummy_field' that stores the velocity. Instead of storing a pointer to the velocity, the changed code was actively copying the entire velocity field, leading to a reduction in performances especially in a already costly simulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to add Algo_QC TRUST/Trio-1.9.2 compatible.
Also fixed a bug in the calculation of the mass flux in the QUICK scheme.