Populate user subjects based on documents #634
Conversation
| end | ||
|
|
||
| def index | ||
| redirect_to new_academic_history_path |
There was a problem hiding this comment.
Por que definis el index si el boton en el menu lleva al new? Se podria sacar?
frankete333
requested review from
EmilioCristalli,
RenzoMinelli and
santiagoguridi
| class PdfProcessor | ||
| include Enumerable | ||
|
|
||
| AcademicEntry = Struct.new(:name, :credits, :number_of_failures, :date_of_completion, :grade) do |
There was a problem hiding this comment.
Creo que deberias mover esto a una clase AcademicHistory::AcademicEntry luego en esa clase podes definir un metodo como save_academic_entry_to_user(user) y moves el codigo que dejaste en el controller para ahi.
Además, asi podemos hacer test sobre esa clase.
| @@ -30,6 +30,8 @@ | |||
|
|
|||
| resources :current_optional_subjects, only: :index | |||
|
|
|||
| resources :academic_histories, only: [:new, :create, :index] | |||
There was a problem hiding this comment.
puede ser que se le llame "transcript" en inglés?
| require 'pdf-reader' | ||
|
|
There was a problem hiding this comment.
| require 'pdf-reader' |
| def index | ||
| redirect_to new_academic_history_path | ||
| end |
There was a problem hiding this comment.
| def index | |
| redirect_to new_academic_history_path | |
| end |
| end | ||
|
|
||
| def create | ||
| file = params[:file] |
There was a problem hiding this comment.
yo usaría params.require(:file), y en el html ponerle required: true
y me parece que después no sería necesario chequear que file exista
| @failed_entries = [] | ||
| @successful_entries = [] | ||
|
|
||
| if file && file.content_type == 'application/pdf' |
There was a problem hiding this comment.
es necesario el file.content_type == 'application/pdf' dado que el html ya tiene accept: "application/pdf"?
si alguien manda un archivo que no es un pdf va a fallar de todas formas?
|
|
||
| def each | ||
| reader.pages.each do |page| | ||
| page.text.split("\n").each do |line| |
There was a problem hiding this comment.
| page.text.split("\n").each do |line| | |
| page.text.each_line do |line| |
no es exactamente lo mismo porque cada línea va a terminar con /n, pero creo que en este caso te sirve igual
| require 'pdf-reader' | ||
|
|
||
| module AcademicHistory | ||
| class PdfProcessor |
There was a problem hiding this comment.
opiniones sobre renombrar esta clase a PdfParser y hacer otro PdfProcessor que llame al parser y después haga lo que está haciendo el controlelr de iterar y crear las materias aprobadas?
|
|
||
| # The date can be either a date in the format DD/MM/YYYY or ********** | ||
| def date_regex | ||
| /\*{10}|\d\d\/\d\d\/\d\d\d\d/ |
There was a problem hiding this comment.
| /\*{10}|\d\d\/\d\d\/\d\d\d\d/ | |
| /\*{10}|\d{2}\/\d{2}\/\d{4}/ |
Screen.Recording.2025-01-21.at.9.56.23.PM.mov