Migrar Sign In a Tailwind
#673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to remove the other helper once we migrate the other views
Was raising this error in browser console:
```
Error connecting controller
TypeError: Cannot read properties of null (reading 'addEventListener')
at Object.registerInteractionHandler (mdc.textfield.js:4414:29)
at MDCRippleFoundation.registerRootHandlers
(mdc.textfield.js:2680:45)
at MDCRippleFoundation.init (mdc.textfield.js:2541:18)
at MDCRipple.MDCComponent (mdc.textfield.js:365:42)
at new MDCRipple (mdc.textfield.js:2081:51)
at rippleFactory (mdc.textfield.js:3851:24)
at MDCTextField.createRipple (mdc.textfield.js:4422:20)
at MDCTextField.initialize (mdc.textfield.js:3932:45)
at MDCTextField.MDCComponent (mdc.textfield.js:358:42)
at new MDCTextField (mdc.textfield.js:3841:46)
{identifier: 'textfield', controller: t, element: div}
```
nicolastemciuc
force-pushed
the
nt--migrate-sign-in
branch
from
ac5f8bc to
77047bb
Compare
| <div class="sm:mx-auto sm:w-full sm:max-w-sm space-y-6"> | ||
| <%= form_with(model: resource, url: session_path(resource_name), class: "space-y-6", local: true) do |f| %> | ||
| <div> | ||
| <%= f.label :email, "Correo electrónico", class: "text-sm/6 font-medium text-indigo-700" %> |
There was a problem hiding this comment.
Me queda un poco raro que el color de la fuente sea el violeta. Creo que me gustaba más en negro como estaba antes, al menos para los textos y eso
There was a problem hiding this comment.
Notable! Me gusta 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Este PR migra el sign in para que use
Tailwinden lugar deMaterial-UIbasado en Tailwind components.