Skip to content

Conversation

mp3butcher
Copy link

@mp3butcher mp3butcher commented Aug 5, 2017

@cedricpinson

  1. morphtarget method parameter
  2. smooth normal generation for morphtargets
  3. (HOT) fix a bug in getChildrenOf (comparator '==' doesnt work, 'is' do)

Julien Valentin added 2 commits August 5, 2017 15:39
next step would be to use blender to_mesh to allow mix of smooth and flat normals
@mp3butcher
Copy link
Author

mp3butcher commented Aug 5, 2017

Without any link with this pr:
I would like to understand why morphtarget doesn't work without baking. I've investigate both in exporter and osganmiation but can't find any clue for this bug. Would you have any lead on this issue?
Thanks in advance

@mp3butcher mp3butcher changed the title add morphtarget method parameter and a smooth normal generation for morphtargets add MT method parameter ,smooth normal generation for MT and correct bug in getChildrenOf Aug 31, 2017
@mp3butcher mp3butcher mentioned this pull request Aug 31, 2017
@AurL
Copy link
Collaborator

AurL commented Sep 1, 2017

Hi @mp3butcher ,

Thanks a lot for the PR and sorry for the delay.
I'll take a look at the changes and give a follow up.

Thanks!
(cc @cedricpinson )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants