This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Make branches updatable with sibling node value #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on #21 (comment) to fix CI, but if you run tests manually they pass now. |
|
Is this a draft or is it complete? I don't see "oldSiblingData" actually being used by anything, it's just being passed around. |
It's complete. |
musalbas
reviewed
Mar 10, 2021
musalbas
reviewed
Mar 10, 2021
musalbas
reviewed
Mar 10, 2021
tzdybal
suggested changes
Mar 12, 2021
Simplify `sideNodesForRoot` function
tzdybal
approved these changes
Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25.
Add sibling node value to proofs if an updatable proof is requested. This allows leaves added via
AddBranchwith updatable proofs to be deleted.