Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Thirdweb along with examples #1794

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Mar 23, 2025

Create a new category in the Dev Environments section called 'using Thirdweb'. Have three pages in that category (Overview, Deploy with Thirdweb CLI, One-Click Deploy)

Update 'Overview' page so that it has the information on the thirdweb portal https://portal.thirdweb.com/ Rename original 'using Thirdweb' content to 'Deploy with Thirdweb CLI' and ensure content is up to date Merge your Thirdweb tutorials into one (since the two tutorials overlap with similar content) and name it 'One-Click Deploy'"

Create a new category in the Dev Environments section called 'using Thirdweb'. Have three pages in that category (Overview, Deploy with Thirdweb CLI, One-Click Deploy)

Update 'Overview' page so that it has the information on the thirdweb portal https://portal.thirdweb.com/
Rename original 'using Thirdweb' content to 'Deploy with Thirdweb CLI' and ensure content is up to date
Merge your Thirdweb tutorials into one (since the two tutorials overlap with similar content) and name it 'One-Click Deploy'"
@atejada atejada requested review from a team as code owners March 23, 2025 16:44
Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for celo-docs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit b4d456a
🔍 Latest deploy log https://app.netlify.com/sites/celo-docs/deploys/67e498d3c0518b0008ed5eb1

10. **Lazy Mint** the NFT.
11. Repeat steps 9 and 10 a few times—we need at least **3 NFTs**.
12. Copy your **`contract address`** from the NFT dashboard.
13. Copy the **`contract address`** from the NFT dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the difference between copy "your" and copy "the"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 😅 Didn't realize it was duplicated...will remove the last one...

git clone https://github.com/celo-org/one-click-quickstart
cd one-click-quickstart
git https://github.com/atejada/celo-one-click-deploy
cd celo-one-click-deploy
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • should be a Celo repo
  • it's missing the "clone" in git clone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the "clone".

And yes, it should be a Celo repo, but I cannot create one ☹️ Could you create one so I can move it or transfer ownership or something?

address and an amount of Celo to transfer. The second link will display an NFT along with its description and by pressing
the mint button, 0.1 Celo will be paid.
address and an amount of Celo to transfer. The second link will display an NTF with a combo box at the top, to choose between 3 different
NFTs. The third and last link will display an NFT along with its description and by pressing the mint button, 0.1 Celo will be paid.

## Join Build with Celo - Proof of Ship

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole section needs to be updated. It should just link to this page with a call to action to build your project on Celo

https://celoplatform.notion.site/Build-With-Celo-Proof-of-Ship-17cd5cb803de8060ba10d22a72b549f8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Although we would need to change the repo from mine to a Celo one

---
title: One-Click Deploy
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is now double

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the extra file. There were 2 tutorials, so I merged them into one but forgot to delete the old one

@@ -69,10 +80,12 @@ Alternatively, you can deploy a prebuilt contract for NFTs, tokens, or marketpla

Deploy allows you to deploy a smart contract to any EVM compatible network without configuring RPC URLs, exposing your private keys, writing scripts, and other additional setup such as verifying your contract.

1. To deploy your smart contract using deploy, navigate to the root directory of your project and execute the following command:
1. Get a [Thirdweb Secret Key](https://thirdweb.com/team/~/~/) if you don't have one already.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMaybe better: Sign Up to thirdweb to get a key and use a generic key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

sidebars.js Outdated
//id: "build/build-with-thirdweb/celo-nft-drop-tutorial",
//},
//],
//},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sidebars.js Outdated
// type: "doc",
// label: "Using thirdweb",
// id: "developer/deploy/thirdweb",
//},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete commented out code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And done

@atejada
Copy link
Contributor Author

atejada commented Mar 25, 2025

@GigaHierz All conversations should be resolved. The only step left is to create a Celo Repo and somehow migrate or fork my repo.

@atejada
Copy link
Contributor Author

atejada commented Mar 25, 2025

For some reason, a merge conflict forced me to delete a big bunch of sidebars.js 😢 I backed it up just in case and will create a new PR to update it once this one is merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants